Azure / Azure/AzLoadBalancerMigration

🪲 Bug Report - AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

Aperta
#158 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
Bicep
Stelle
11
Fork
18
Merge medio
1g 8h
PR unite (30g)
3

Descrizione

## Describe the bug
AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

## To Reproduce

Steps to reproduce the behavior:

1. Excute the script to the VM with no public IP address resource in given AvSet.
2. Logged: `[WARNING] VM '' does not have any public IP addresses attached. Skipping upgrade.`
4. Then Logged `[INFO] ####### Upgrade process complete. #######`. The other VMs which has public IP addresses are also skipped.

## Expected behavior
The VMs which has public IP addresses should be upgraded.
The VMs which has no public IP addresses should be skipped.

"return" statements in line 224 and 235 should be replaced in "continue" statements.

## Screenshots 📷

Image

## Additional context - please include:

- Version of the AzureBasicLoadBalancerUpgrade module you are running (see: `Get-Module AzureBasicLoadBalancerUpgrade` after importing the module.): 1.0.0

Image

- Version of PowerShell you are running (`$PSVersionTable`)

Image

- The JSON View or template of the VMSS and Load Balancer(s) to be migrated
N/A

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start in the AzureAvSetBasicPublicIPUpgrade module around lines 224 and 235, where the issue identifies the return statements. Reproduce the case with a VM lacking a public IP and other VMs with public IPs; done means the former is skipped while the latter continue through the upgrade process.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
azure, powershell
Ambito
cloud, infrastructure
Tipo di issue
Bug
Difficoltà
1/5
Tempo stimato
Meno di un'ora
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
58/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.