Azure / Azure/AzLoadBalancerMigration

🪲 Bug Report - AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

Offen
#158 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
Bicep
Sterne
11
Forks
18
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
3

Beschreibung

## Describe the bug
AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

## To Reproduce

Steps to reproduce the behavior:

1. Excute the script to the VM with no public IP address resource in given AvSet.
2. Logged: `[WARNING] VM '' does not have any public IP addresses attached. Skipping upgrade.`
4. Then Logged `[INFO] ####### Upgrade process complete. #######`. The other VMs which has public IP addresses are also skipped.

## Expected behavior
The VMs which has public IP addresses should be upgraded.
The VMs which has no public IP addresses should be skipped.

"return" statements in line 224 and 235 should be replaced in "continue" statements.

## Screenshots 📷

Image

## Additional context - please include:

- Version of the AzureBasicLoadBalancerUpgrade module you are running (see: `Get-Module AzureBasicLoadBalancerUpgrade` after importing the module.): 1.0.0

Image

- Version of PowerShell you are running (`$PSVersionTable`)

Image

- The JSON View or template of the VMSS and Load Balancer(s) to be migrated
N/A

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start in the AzureAvSetBasicPublicIPUpgrade module around lines 224 and 235, where the issue identifies the return statements. Reproduce the case with a VM lacking a public IP and other VMs with public IPs; done means the former is skipped while the latter continue through the upgrade process.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
azure, powershell
Bereich
cloud, infrastructure
Issue-Typ
Bug
Schwierigkeit
1/5
Geschätzter Aufwand
Unter einer Stunde
Aktivitätsstatus
Veraltet
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
58/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.