Azure / Azure/AzLoadBalancerMigration

🪲 Bug Report - AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

Open
#158 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Bicep
Stars
11
Forks
18
Avg merge
1d 8h
Merged PRs (30d)
3

Description

## Describe the bug
AzureAvSetBasicPublicIPUpgrade: "Skipping upgrade" does not work due to "return" statement.

## To Reproduce

Steps to reproduce the behavior:

1. Excute the script to the VM with no public IP address resource in given AvSet.
2. Logged: `[WARNING] VM '' does not have any public IP addresses attached. Skipping upgrade.`
4. Then Logged `[INFO] ####### Upgrade process complete. #######`. The other VMs which has public IP addresses are also skipped.

## Expected behavior
The VMs which has public IP addresses should be upgraded.
The VMs which has no public IP addresses should be skipped.

"return" statements in line 224 and 235 should be replaced in "continue" statements.

## Screenshots 📷

Image

## Additional context - please include:

- Version of the AzureBasicLoadBalancerUpgrade module you are running (see: `Get-Module AzureBasicLoadBalancerUpgrade` after importing the module.): 1.0.0

Image

- Version of PowerShell you are running (`$PSVersionTable`)

Image

- The JSON View or template of the VMSS and Load Balancer(s) to be migrated
N/A

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.