AlphaWallet / AlphaWallet/alpha-wallet-android

Add AddressBook to InputAddress component

Aperta
#1,672 4 commenti 0 reazioni 1 assegnatario Rivendicata da @asif-finimble Vedi su GitHub
For Review
Lingua principale
Java
Stelle
646
Fork
579
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The AddressBook enhancement needs to be added to the InputAddress component:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76

Here's the AddressBook screen detail:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address

Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.

The addressbook should be switchable from the layout via a ```custom:addressbook="true"``` kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.

It may also need an entry in the settings page; check the zeplin spec.

You should work off the 'Component Upgrade' branch, as the new components are on that one.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.