AlphaWallet / AlphaWallet/alpha-wallet-android

Add AddressBook to InputAddress component

Ouverte
#1,672 4 commentaires 0 réactions 1 personne assignée Réclamée par @asif-finimble Voir sur GitHub
For Review
Langage dominant
Java
Étoiles
646
Forks
579
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

The AddressBook enhancement needs to be added to the InputAddress component:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76

Here's the AddressBook screen detail:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address

Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.

The addressbook should be switchable from the layout via a ```custom:addressbook="true"``` kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.

It may also need an entry in the settings page; check the zeplin spec.

You should work off the 'Component Upgrade' branch, as the new components are on that one.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.