AlphaWallet / AlphaWallet/alpha-wallet-android

Add AddressBook to InputAddress component

Abierto
#1,672 4 comentarios 0 reacciones 1 asignado Reclamado por @asif-finimble Ver en GitHub
For Review
Lenguaje dominante
Java
Estrellas
646
Forks
579
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The AddressBook enhancement needs to be added to the InputAddress component:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76

Here's the AddressBook screen detail:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address

Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.

The addressbook should be switchable from the layout via a ```custom:addressbook="true"``` kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.

It may also need an entry in the settings page; check the zeplin spec.

You should work off the 'Component Upgrade' branch, as the new components are on that one.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.