AlphaWallet / AlphaWallet/alpha-wallet-android

Add AddressBook to InputAddress component

Offen
#1,672 4 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @asif-finimble Auf GitHub ansehen
For Review
Vorherrschende Sprache
Java
Sterne
646
Forks
579
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

The AddressBook enhancement needs to be added to the InputAddress component:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e21a0f6af7b8d2e33cfad76

Here's the AddressBook screen detail:

https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?q=address

Ideally the AddressBook Activity is hooked to the InputAddress component, so by dropping in the InputAddress component you have access to the addressbook without needing to add anything to the host activity.

The addressbook should be switchable from the layout via a ```custom:addressbook="true"``` kind of control, and should default to false so it's only added where needed. Looks like it should be added into SendActivity and TicketTransferDetailActivity. I haven't seen any other places it should be added.

It may also need an entry in the settings page; check the zeplin spec.

You should work off the 'Component Upgrade' branch, as the new components are on that one.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.