AllenNeuralDynamics / AllenNeuralDynamics/aind-data-access-api

Remove or update `add_qc_evaluations_to_docdb`

未關閉
#217 2 則留言 0 個 reaction 已指派 1 人 已被 @dougollerenshaw 認領 在 GitHub 檢視
主要語言
Python
星號
3
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

I was trying to figure out how to use the `add_qc_evaluations_to_docdb` function here:
https://github.com/AllenNeuralDynamics/aind-data-access-api/blob/d3c204f62a9e48e50cfc8e6ab789d33e7c846871/src/aind_data_access_api/helpers/data_schema.py#L187

I reached out to Dan, and he said this is only valid for V1 metadata. It sounds like this would corrupt a v2 asset if someone tried to use this against a v2 asset.

Since schema v1 is no longer supported, I don't think we should keep a function that is only valid for v1.

We should either remove this function or add a deprecation warning when it's used.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。