AllenNeuralDynamics / AllenNeuralDynamics/aind-data-access-api

Remove or update `add_qc_evaluations_to_docdb`

未关闭
#217 2 条评论 0 个 reaction 已指派 1 人 已被 @dougollerenshaw 认领 在 GitHub 查看
主要语言
Python
星标
3
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

I was trying to figure out how to use the `add_qc_evaluations_to_docdb` function here:
https://github.com/AllenNeuralDynamics/aind-data-access-api/blob/d3c204f62a9e48e50cfc8e6ab789d33e7c846871/src/aind_data_access_api/helpers/data_schema.py#L187

I reached out to Dan, and he said this is only valid for V1 metadata. It sounds like this would corrupt a v2 asset if someone tried to use this against a v2 asset.

Since schema v1 is no longer supported, I don't think we should keep a function that is only valid for v1.

We should either remove this function or add a deprecation warning when it's used.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。