AllenNeuralDynamics / AllenNeuralDynamics/aind-data-access-api

Remove or update `add_qc_evaluations_to_docdb`

Open
#217 2 comments 0 reactions 1 assignee Claimed by @dougollerenshaw View on GitHub
Dominant language
Python
Stars
3
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I was trying to figure out how to use the `add_qc_evaluations_to_docdb` function here:
https://github.com/AllenNeuralDynamics/aind-data-access-api/blob/d3c204f62a9e48e50cfc8e6ab789d33e7c846871/src/aind_data_access_api/helpers/data_schema.py#L187

I reached out to Dan, and he said this is only valid for V1 metadata. It sounds like this would corrupt a v2 asset if someone tried to use this against a v2 asset.

Since schema v1 is no longer supported, I don't think we should keep a function that is only valid for v1.

We should either remove this function or add a deprecation warning when it's used.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.