AllenNeuralDynamics / AllenNeuralDynamics/aind-data-access-api

Remove or update `add_qc_evaluations_to_docdb`

Aperta
#217 2 commenti 0 reazioni 1 assegnatario Rivendicata da @dougollerenshaw Vedi su GitHub
Lingua principale
Python
Stelle
3
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I was trying to figure out how to use the `add_qc_evaluations_to_docdb` function here:
https://github.com/AllenNeuralDynamics/aind-data-access-api/blob/d3c204f62a9e48e50cfc8e6ab789d33e7c846871/src/aind_data_access_api/helpers/data_schema.py#L187

I reached out to Dan, and he said this is only valid for V1 metadata. It sounds like this would corrupt a v2 asset if someone tried to use this against a v2 asset.

Since schema v1 is no longer supported, I don't think we should keep a function that is only valid for v1.

We should either remove this function or add a deprecation warning when it's used.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.