AlexConnat / AlexConnat/PracticeJazzChords

Proper names of notes

未關閉
#2 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
JavaScript
星號
0
分支
0
PR 合併指標
30 天內沒有已合併 PR

描述

The name of displayed notes when played on the keyboard is **always the same**, whereas they should depend on the context of the chord. For instance, in a Ebmin7 chord, the 3rd should be "Gb", and not "F#".

Same goes for the chords themselves. We will never be displayed a C#maj7 chord for instance, because "C#" does not exist in the set of available root notes. Only "Db" is hardcoded in the `midiPitchToNoteName` object. Being asked for both would add a bit more variety to the game and would be closer to a real-life situation, i.e facing a lead sheet.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。