AlexConnat / AlexConnat/PracticeJazzChords

Proper names of notes

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The name of displayed notes when played on the keyboard is **always the same**, whereas they should depend on the context of the chord. For instance, in a Ebmin7 chord, the 3rd should be "Gb", and not "F#".

Same goes for the chords themselves. We will never be displayed a C#maj7 chord for instance, because "C#" does not exist in the set of available root notes. Only "Db" is hardcoded in the `midiPitchToNoteName` object. Being asked for both would add a bit more variety to the game and would be closer to a real-life situation, i.e facing a lead sheet.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.