AlexConnat / AlexConnat/PracticeJazzChords

Proper names of notes

Aperta
#2 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
JavaScript
Stelle
0
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The name of displayed notes when played on the keyboard is **always the same**, whereas they should depend on the context of the chord. For instance, in a Ebmin7 chord, the 3rd should be "Gb", and not "F#".

Same goes for the chords themselves. We will never be displayed a C#maj7 chord for instance, because "C#" does not exist in the set of available root notes. Only "Db" is hardcoded in the `midiPitchToNoteName` object. Being asked for both would add a bit more variety to the game and would be closer to a real-life situation, i.e facing a lead sheet.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.