AlexConnat / AlexConnat/PracticeJazzChords
Proper names of notes
未关闭
bug
- 主要语言
- JavaScript
- 星标
- 0
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
描述
The name of displayed notes when played on the keyboard is **always the same**, whereas they should depend on the context of the chord. For instance, in a Ebmin7 chord, the 3rd should be "Gb", and not "F#".
Same goes for the chords themselves. We will never be displayed a C#maj7 chord for instance, because "C#" does not exist in the set of available root notes. Only "Db" is hardcoded in the `midiPitchToNoteName` object. Being asked for both would add a bit more variety to the game and would be closer to a real-life situation, i.e facing a lead sheet.
贡献指南
这个仓库没有索引到贡献指南
评估
这个 Issue 还没有评估数据。