AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

Config's setActiveViews doesn't support views with commas in the name

オープン
#2,086 コメント 0 件 リアクション 0 件 担当者 1 名 @doug-walker が担当を希望しています GitHub で見る
Bug
主要言語
C++
スター
2.1k
フォーク
505
PR マージ指標
30日以内にマージされた PR はありません

説明

Commas are used as a separator for the string passed to setActiveViews or received from getActiveViews. If a view name has a comma, it will be treated as a separator and essentially break the config.

When serializing a config file, OCIO uses quotes in the YAML to package certain strings that contain commas, such as color spaces and view transforms. So it is possible to get commas through the YAML parsing. However they are not handled by SplitStringEnvStyle in ParseUtils.cpp which is used to tokenize the string argument to setActiveViews.

The proposal is that SplitStringEnvStyle be upgraded to handle quotes similar to how they work in YAML, as a way to separate string tokens that may contain commas. Similarly, JoinStringEnvStyle should be upgraded to quote names with commas.

A similar problem exists with setActiveDisplays and would be fixed at the same time, since it uses SplitStringEnvStyle.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。