AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO
Config's setActiveViews doesn't support views with commas in the name
@doug-walker ya está trabajando en esto.
Desde el 4/1/2025.
- Lenguaje dominante
- C++
- Estrellas
- 2.1k
- Forks
- 505
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Commas are used as a separator for the string passed to setActiveViews or received from getActiveViews. If a view name has a comma, it will be treated as a separator and essentially break the config.
When serializing a config file, OCIO uses quotes in the YAML to package certain strings that contain commas, such as color spaces and view transforms. So it is possible to get commas through the YAML parsing. However they are not handled by SplitStringEnvStyle in ParseUtils.cpp which is used to tokenize the string argument to setActiveViews.
The proposal is that SplitStringEnvStyle be upgraded to handle quotes similar to how they work in YAML, as a way to separate string tokens that may contain commas. Similarly, JoinStringEnvStyle should be upgraded to quote names with commas.
A similar problem exists with setActiveDisplays and would be fixed at the same time, since it uses SplitStringEnvStyle.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Evaluación
Este issue todavía no se ha evaluado.