AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

Config's setActiveViews doesn't support views with commas in the name

Offen
#2,086 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @doug-walker Auf GitHub ansehen
Bug
Vorherrschende Sprache
C++
Sterne
2.1k
Forks
503
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Commas are used as a separator for the string passed to setActiveViews or received from getActiveViews. If a view name has a comma, it will be treated as a separator and essentially break the config.

When serializing a config file, OCIO uses quotes in the YAML to package certain strings that contain commas, such as color spaces and view transforms. So it is possible to get commas through the YAML parsing. However they are not handled by SplitStringEnvStyle in ParseUtils.cpp which is used to tokenize the string argument to setActiveViews.

The proposal is that SplitStringEnvStyle be upgraded to handle quotes similar to how they work in YAML, as a way to separate string tokens that may contain commas. Similarly, JoinStringEnvStyle should be upgraded to quote names with commas.

A similar problem exists with setActiveDisplays and would be fixed at the same time, since it uses SplitStringEnvStyle.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.