AbsaOSS / AbsaOSS/enceladus

Refactor Validation Utils

未关闭
#57 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Conformance good first issue priority: undecided refactoring
主要语言
Scala
星标
33
派生
16
PR 合并指标
30 天内没有已合并 PR

描述

We have two separate ValidationExceptions:

* za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
* za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance)
Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。