AbsaOSS / AbsaOSS/enceladus

Refactor Validation Utils

Ouverte
#57 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Conformance good first issue priority: undecided refactoring
Langage dominant
Scala
Étoiles
33
Forks
16
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

We have two separate ValidationExceptions:

* za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
* za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance)
Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.