AbsaOSS / AbsaOSS/enceladus

Refactor Validation Utils

Abierto
#57 1 comentario 0 reacciones 0 asignados Ver en GitHub
Conformance good first issue priority: undecided refactoring
Lenguaje dominante
Scala
Estrellas
33
Forks
16
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

We have two separate ValidationExceptions:

* za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
* za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance)
Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.