AbsaOSS / AbsaOSS/enceladus

Refactor Validation Utils

Aperta
#57 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Conformance good first issue priority: undecided refactoring
Lingua principale
Scala
Stelle
33
Fork
16
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

We have two separate ValidationExceptions:

* za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
* za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance)
Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.