AbsaOSS / AbsaOSS/enceladus

Refactor Validation Utils

Open
#57 1 comment 0 reactions 0 assignees View on GitHub
Conformance good first issue priority: undecided refactoring
Dominant language
Scala
Stars
33
Forks
16
PR merge metrics
No merged PRs in 30d

Description

We have two separate ValidationExceptions:

* za.co.absa.enceladus.conformance.interpreter.rules.ValidationException (only used in Standardization)
* za.co.absa.enceladus.utils.validation.ValidationException (only used in Conformance)
Conformance also dips into za.co.absa.enceladus.utils.validation.ValidationUtils before throwing its own ValidationException, which blurs the line between which ValidationException is responsible for what.

Good design dictates a clear separation between the two or a unification.

There is also some code duplication in conformance rules, specifically aimed at validation, that would best be extracted to a common location.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.