0xMiden / 0xMiden/rust-sdk

feat: ensure that both the account and public key get inserted successfully in the CLI

未关闭
#731 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
78
派生
129
平均合并
4 天 14 小时
30 天内合并 PR
52

描述

In #718 we separated the secret key storage from the `Client`. The CLI now has the responsibility of adding new keys to the keystore, but there could be a case where the key is inserted but the new account can be added to the client.

>This is fine for now but maybe we could add a `TODO` here to address potential cases where adding the secret key succeeds, but adding the account fails.
>
>Alternatively, maybe in the future we want to have some sort of "keystore" command that adds/removes keys separately from accounts.

_Originally posted by @igamigo in https://github.com/0xPolygonMiden/miden-client/pull/718#discussion_r1949770347_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。