0xMiden / 0xMiden/rust-sdk

feat: ensure that both the account and public key get inserted successfully in the CLI

Offen
#731 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
78
Forks
129
Ø Merge
4 T. 14 Std.
Gemergte PRs (30 T.)
52

Beschreibung

In #718 we separated the secret key storage from the `Client`. The CLI now has the responsibility of adding new keys to the keystore, but there could be a case where the key is inserted but the new account can be added to the client.

>This is fine for now but maybe we could add a `TODO` here to address potential cases where adding the secret key succeeds, but adding the account fails.
>
>Alternatively, maybe in the future we want to have some sort of "keystore" command that adds/removes keys separately from accounts.

_Originally posted by @igamigo in https://github.com/0xPolygonMiden/miden-client/pull/718#discussion_r1949770347_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.