0xMiden / 0xMiden/rust-sdk

feat: ensure that both the account and public key get inserted successfully in the CLI

Open
#731 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
78
Forks
129
Avg merge
4d 14h
Merged PRs (30d)
52

Description

In #718 we separated the secret key storage from the `Client`. The CLI now has the responsibility of adding new keys to the keystore, but there could be a case where the key is inserted but the new account can be added to the client.

>This is fine for now but maybe we could add a `TODO` here to address potential cases where adding the secret key succeeds, but adding the account fails.
>
>Alternatively, maybe in the future we want to have some sort of "keystore" command that adds/removes keys separately from accounts.

_Originally posted by @igamigo in https://github.com/0xPolygonMiden/miden-client/pull/718#discussion_r1949770347_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.