0xMiden / 0xMiden/rust-sdk

feat: ensure that both the account and public key get inserted successfully in the CLI

Abierto
#731 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
78
Forks
129
Merge medio
4 d 14 h
PR fusionados (30 d)
52

Descripción

In #718 we separated the secret key storage from the `Client`. The CLI now has the responsibility of adding new keys to the keystore, but there could be a case where the key is inserted but the new account can be added to the client.

>This is fine for now but maybe we could add a `TODO` here to address potential cases where adding the secret key succeeds, but adding the account fails.
>
>Alternatively, maybe in the future we want to have some sort of "keystore" command that adds/removes keys separately from accounts.

_Originally posted by @igamigo in https://github.com/0xPolygonMiden/miden-client/pull/718#discussion_r1949770347_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.