Consider revisiting `NoteFile` variants
未关闭
- 主要语言
- Rust
- 星标
- 132
- 派生
- 167
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 110
描述
> Not related to this PR, but I do wonder whether it was a good idea to include `NoteId` as a variant in this enum. Seems like it is somewhat misleading that `NoteFile` contains just the note ID.
_Originally posted by @bobbinth in https://github.com/0xMiden/miden-base/pull/1976#discussion_r2413015698_
The `NoteFile` enum was added mainly to support the concept of note importing/exporting. Specifically, the idea of the `NoteId` variant was to be a way of communicating public note IDs that could be retrieved from the node.
贡献指南
评估
这个 Issue 还没有评估数据。