Consider revisiting `NoteFile` variants
Ouverte
- Langage dominant
- Rust
- Étoiles
- 132
- Forks
- 167
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 110
Description
> Not related to this PR, but I do wonder whether it was a good idea to include `NoteId` as a variant in this enum. Seems like it is somewhat misleading that `NoteFile` contains just the note ID.
_Originally posted by @bobbinth in https://github.com/0xMiden/miden-base/pull/1976#discussion_r2413015698_
The `NoteFile` enum was added mainly to support the concept of note importing/exporting. Specifically, the idea of the `NoteId` variant was to be a way of communicating public note IDs that could be retrieved from the node.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.