0xMiden / 0xMiden/protocol

Consider revisiting `NoteFile` variants

Abierto
#1,983 6 comentarios 0 reacciones 1 asignado Reclamado por @igamigo Ver en GitHub
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

> Not related to this PR, but I do wonder whether it was a good idea to include `NoteId` as a variant in this enum. Seems like it is somewhat misleading that `NoteFile` contains just the note ID.

_Originally posted by @bobbinth in https://github.com/0xMiden/miden-base/pull/1976#discussion_r2413015698_

The `NoteFile` enum was added mainly to support the concept of note importing/exporting. Specifically, the idea of the `NoteId` variant was to be a way of communicating public note IDs that could be retrieved from the node.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.