0xMiden / 0xMiden/protocol

Consider revisiting `NoteFile` variants

Offen
#1,983 6 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @igamigo Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
132
Forks
167
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
110

Beschreibung

> Not related to this PR, but I do wonder whether it was a good idea to include `NoteId` as a variant in this enum. Seems like it is somewhat misleading that `NoteFile` contains just the note ID.

_Originally posted by @bobbinth in https://github.com/0xMiden/miden-base/pull/1976#discussion_r2413015698_

The `NoteFile` enum was added mainly to support the concept of note importing/exporting. Specifically, the idea of the `NoteId` variant was to be a way of communicating public note IDs that could be retrieved from the node.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.