07th-mod / 07th-mod/python-patcher

Add workaround for occasional SSL errors

未關閉
#189 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
214
分支
12
PR 合併指標
30 天內沒有已合併 PR

描述

We occasionally get users who cannot download using our installer using Aria2c, with a

`SSL/TLS handshake failure: Error: The revocation function was unable to check revocation because the revocation server was offline.`

Most recently, a Windows user reported this issue, who had no problem with installing ch1-3, but only on ch4 had this issue. Interestingly the installer will only show a warning on startup, despite not being able to download from the https of 07th-mod server, and startup will take a very long time. But the installer will still continue anyway.

See https://07th-mod.com/wiki/Installer/faq/#download-or-init-stage-fails-i-get-a-ssltls-handshake-failure-from-aria2c for more details

Usually, they can still download via their browser (and I'm unsure as to why).

There are a couple of workarounds for this:

- Implement https://github.com/07th-mod/python-patcher/issues/188 - download manually, but install automatically option, then let the user manually download all the files.
- The downside of this option is the user still needs to manually manage/download all the files
- Add an option to disable SSL (transform all https:// links to http://). This is already done for the 'query' stage on MacOS to bypass some MacOS SSL errors on old MacOS, but not for the actual download portion to ensure the download is still secure.
- This is generally a *bad idea* but still an option.
- Use a different download tool than Aria2c/add different tool as fallback
- From memory, this issue only affects Aria2c and not other download tools, but I would need to verify this

貢獻指南

這個儲存庫沒有索引到貢獻指南

研究方向

查看安裝程式中的下載邏輯,很可能在處理 aria2c 呼叫的檔案中。該問題提到了 macOS 上查詢的現有 SSL 繞過;找到該程式碼以理解其模式。檢查 URL 是如何轉換的以及 aria2c 在何處被呼叫。測試需要模擬 SSL 錯誤或向遇到這些錯誤的使用者進行核實。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript, python
領域
cli, tooling
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。