07th-mod / 07th-mod/python-patcher
Add workaround for occasional SSL errors
- 主要语言
- JavaScript
- 星标
- 214
- 派生
- 12
- PR 合并指标
- 30 天内没有已合并 PR
描述
We occasionally get users who cannot download using our installer using Aria2c, with a
`SSL/TLS handshake failure: Error: The revocation function was unable to check revocation because the revocation server was offline.`
Most recently, a Windows user reported this issue, who had no problem with installing ch1-3, but only on ch4 had this issue. Interestingly the installer will only show a warning on startup, despite not being able to download from the https of 07th-mod server, and startup will take a very long time. But the installer will still continue anyway.
See https://07th-mod.com/wiki/Installer/faq/#download-or-init-stage-fails-i-get-a-ssltls-handshake-failure-from-aria2c for more details
Usually, they can still download via their browser (and I'm unsure as to why).
There are a couple of workarounds for this:
- Implement https://github.com/07th-mod/python-patcher/issues/188 - download manually, but install automatically option, then let the user manually download all the files.
- The downside of this option is the user still needs to manually manage/download all the files
- Add an option to disable SSL (transform all https:// links to http://). This is already done for the 'query' stage on MacOS to bypass some MacOS SSL errors on old MacOS, but not for the actual download portion to ensure the download is still secure.
- This is generally a *bad idea* but still an option.
- Use a different download tool than Aria2c/add different tool as fallback
- From memory, this issue only affects Aria2c and not other download tools, but I would need to verify this
贡献指南
这个仓库没有索引到贡献指南
调研方向
查看安装程序中的下载逻辑,很可能在处理 aria2c 调用的文件中。该问题提到了 macOS 上查询的现有 SSL 绕过;找到该代码以理解其模式。检查 URL 是如何转换的以及 aria2c 在何处被调用。测试需要模拟 SSL 错误或向遇到这些错误的用户进行核实。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, python
- 领域
- cli, tooling
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100