07th-mod / 07th-mod/python-patcher
Add workaround for occasional SSL errors
- Langage dominant
- JavaScript
- Étoiles
- 214
- Forks
- 12
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
We occasionally get users who cannot download using our installer using Aria2c, with a
`SSL/TLS handshake failure: Error: The revocation function was unable to check revocation because the revocation server was offline.`
Most recently, a Windows user reported this issue, who had no problem with installing ch1-3, but only on ch4 had this issue. Interestingly the installer will only show a warning on startup, despite not being able to download from the https of 07th-mod server, and startup will take a very long time. But the installer will still continue anyway.
See https://07th-mod.com/wiki/Installer/faq/#download-or-init-stage-fails-i-get-a-ssltls-handshake-failure-from-aria2c for more details
Usually, they can still download via their browser (and I'm unsure as to why).
There are a couple of workarounds for this:
- Implement https://github.com/07th-mod/python-patcher/issues/188 - download manually, but install automatically option, then let the user manually download all the files.
- The downside of this option is the user still needs to manually manage/download all the files
- Add an option to disable SSL (transform all https:// links to http://). This is already done for the 'query' stage on MacOS to bypass some MacOS SSL errors on old MacOS, but not for the actual download portion to ensure the download is still secure.
- This is generally a *bad idea* but still an option.
- Use a different download tool than Aria2c/add different tool as fallback
- From memory, this issue only affects Aria2c and not other download tools, but I would need to verify this
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Examinez la logique de téléchargement dans l'installateur, probablement dans un fichier gérant les appels aria2c. Le problème mentionne un contournement SSL existant pour les requêtes sur macOS ; trouvez ce code pour comprendre le modèle. Vérifiez comment les URL sont transformées et où aria2c est invoqué. Les tests nécessiteront de simuler des erreurs SSL ou de vérifier auprès des utilisateurs qui les rencontrent.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- javascript, python
- Domaine
- cli, tooling
- Type d'issue
- Fonctionnalité
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100