07th-mod / 07th-mod/python-patcher

Add workaround for occasional SSL errors

Aberta
#189 1 comentário 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
JavaScript
Estrelas
214
Forks
12
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

We occasionally get users who cannot download using our installer using Aria2c, with a

`SSL/TLS handshake failure: Error: The revocation function was unable to check revocation because the revocation server was offline.`

Most recently, a Windows user reported this issue, who had no problem with installing ch1-3, but only on ch4 had this issue. Interestingly the installer will only show a warning on startup, despite not being able to download from the https of 07th-mod server, and startup will take a very long time. But the installer will still continue anyway.

See https://07th-mod.com/wiki/Installer/faq/#download-or-init-stage-fails-i-get-a-ssltls-handshake-failure-from-aria2c for more details

Usually, they can still download via their browser (and I'm unsure as to why).

There are a couple of workarounds for this:

- Implement https://github.com/07th-mod/python-patcher/issues/188 - download manually, but install automatically option, then let the user manually download all the files.
- The downside of this option is the user still needs to manually manage/download all the files
- Add an option to disable SSL (transform all https:// links to http://). This is already done for the 'query' stage on MacOS to bypass some MacOS SSL errors on old MacOS, but not for the actual download portion to ensure the download is still secure.
- This is generally a *bad idea* but still an option.
- Use a different download tool than Aria2c/add different tool as fallback
- From memory, this issue only affects Aria2c and not other download tools, but I would need to verify this

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Analise a lógica de download no instalador, provavelmente em um arquivo que lida com chamadas aria2c. O problema menciona uma bypass SSL existente para consultas no macOS; encontre esse código para entender o padrão. Verifique como as URLs são transformadas e onde o aria2c é invocado. Os testes exigirão simular erros SSL ou verificar com usuários que os encontram.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
javascript, python
Domínio
cli, tooling
Tipo de issue
Funcionalidade
Dificuldade
4/5
Tempo estimado
3-5 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
45/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.