test_minidom has many empty tests

未关闭
#63,882 22 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
20/100
Issue 类型
重构
描述清晰度
需要澄清
活跃度
停滞
技术栈
python
领域
testing

调研方向

Start by reviewing the test_minidom tests and the related minidom.py changes mentioned in the issue. Check the historical patches and PR 24152 to determine whether any empty tests or requested test revisions remain; done would mean the intended test cleanup is complete and the test suite passes.

由索引模型根据 Issue 内容生成。

描述

easy tests topic-XML type-feature
BPO 19683
Nosy @bitdancer, @karlcow, @zware, @serhiy-storchaka
PRs
  • python/cpython#24152
    		•
    Files
  • issue19683.patch
  • issue19683.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Edit by TJR: The two patch files, by two different people deleted empty tests. Some version was merged to Python maintenance versions 2.7 and 3.3 (then on Mercurial) in Dec 2013: https://github.com/python/cpython/issues/63882#issuecomment-1093635363. At that time, 3.4.0, released in March 2014, was tip. PR 24152 added docstrings to minidom.py, removed the empty tests, and revised existing tests. The author closed it due to lack of time when requested to split it into multiple PRs.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-11-21.15:17:39.634>
labels = ['easy', 'type-feature', 'tests']
title = 'test_minidom has many empty tests'
updated_at = <Date 2021-01-07.13:48:32.590>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2021-01-07.13:48:32.590>
actor = 'karlcow'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-21.15:17:39.634>
creator = 'zach.ware'
dependencies = []
files = ['32901', '33258']
hgrepos = []
issue_num = 19683
keywords = ['patch', 'easy']
message_count = 21.0
messages = ['203637', '203642', '203643', '204781', '204806', '204834', '205274', '206637', '206639', '206641', '206642', '206873', '206939', '206979', '209897', '209899', '353793', '353835', '384561', '384575', '384576']
nosy_count = 7.0
nosy_names = ['r.david.murray', 'karlcow', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'Julian.Gindi', 'ajitesh.gupta']
pr_nums = ['24152']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19683'
versions = ['Python 3.4']

    Linked PRs
    • gh-128477
    • gh-128948
    • gh-132879
    • gh-133000
    • gh-133024
    • gh-133026
    • gh-133029
    • gh-133451
    • gh-156677
    • gh-157426
    • gh-157427
    • gh-157428
    主要语言
    Python
    星标
    77.2k
    派生
    36k
    平均合并
    1 天 9 小时
    30 天内合并 PR
    558

    贡献指南

    打开贡献指南

    从这里开始

    1. 先读完整个 Issue，再读项目的贡献指南。
    2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
    3. Fork 仓库，在一个分支上完成修改。
    4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

    python/cpython 的其他 Issue

    查看 python/cpython 的全部 Issue

    相似的 Issue

    更多 Python Issue

    把新 issue 发到你的邮箱

    精选适合新手参与的 GitHub issue 摘要。