test_minidom has many empty tests

Aperta
#63,882 22 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
20/100
Tipo di issue
Refactoring
Chiarezza
Da chiarire
Stato di attività
Ferma
Stack tecnologico
python
Ambito
testing

Direzione di ricerca

Start by reviewing the test_minidom tests and the related minidom.py changes mentioned in the issue. Check the historical patches and PR 24152 to determine whether any empty tests or requested test revisions remain; done would mean the intended test cleanup is complete and the test suite passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

easy tests topic-XML type-feature
BPO 19683
Nosy @bitdancer, @karlcow, @zware, @serhiy-storchaka
PRs
  • python/cpython#24152
    		•
    Files
  • issue19683.patch
  • issue19683.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Edit by TJR: The two patch files, by two different people deleted empty tests. Some version was merged to Python maintenance versions 2.7 and 3.3 (then on Mercurial) in Dec 2013: https://github.com/python/cpython/issues/63882#issuecomment-1093635363. At that time, 3.4.0, released in March 2014, was tip. PR 24152 added docstrings to minidom.py, removed the empty tests, and revised existing tests. The author closed it due to lack of time when requested to split it into multiple PRs.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-11-21.15:17:39.634>
labels = ['easy', 'type-feature', 'tests']
title = 'test_minidom has many empty tests'
updated_at = <Date 2021-01-07.13:48:32.590>
user = 'https://github.com/zware'

    bugs.python.org fields:

    activity = <Date 2021-01-07.13:48:32.590>
actor = 'karlcow'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-21.15:17:39.634>
creator = 'zach.ware'
dependencies = []
files = ['32901', '33258']
hgrepos = []
issue_num = 19683
keywords = ['patch', 'easy']
message_count = 21.0
messages = ['203637', '203642', '203643', '204781', '204806', '204834', '205274', '206637', '206639', '206641', '206642', '206873', '206939', '206979', '209897', '209899', '353793', '353835', '384561', '384575', '384576']
nosy_count = 7.0
nosy_names = ['r.david.murray', 'karlcow', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'Julian.Gindi', 'ajitesh.gupta']
pr_nums = ['24152']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19683'
versions = ['Python 3.4']

    Linked PRs
    • gh-128477
    • gh-128948
    • gh-132879
    • gh-133000
    • gh-133024
    • gh-133026
    • gh-133029
    • gh-133451
    • gh-156677
    • gh-157426
    • gh-157427
    • gh-157428
    Lingua principale
    Python
    Stelle
    77.2k
    Fork
    36k
    Merge medio
    1g 9h
    PR unite (30g)
    558

    Guida per i contributori

    Apri la guida per i contributori

    Come iniziare

    1. Leggi tutta la issue e poi la guida ai contributi del progetto.
    2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
    3. Fai un fork del repository e lavora su un branch.
    4. Apri una pull request che faccia riferimento al numero della issue.

    Altre issue di python/cpython

    Tutte le issue di python/cpython

    Issue simili

    Altre issue su Python

    Ricevi le nuove issue nella tua casella

    Un breve riepilogo di issue GitHub adatte ai principianti.