test_minidom has many empty tests

未關閉

#63,882 建立於 2013年11月21日 22 則留言 0 個 reaction 已指派 0 人在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度: 2/5
預估耗時: 1-3 小時
新手友好度: 20/100

Issue 類型: 重構
描述清晰度: 需要釐清
活躍度: 停滯
技術堆疊: python
領域: testing

研究方向

Start by reviewing the test_minidom tests and the related minidom.py changes mentioned in the issue. Check the historical patches and PR 24152 to determine whether any empty tests or requested test revisions remain; done would mean the intended test cleanup is complete and the test suite passes.

由索引模型根據 Issue 內容生成。

描述

easy tests topic-XML type-feature

BPO	19683
Nosy	@bitdancer, @karlcow, @zware, @serhiy-storchaka
PRs	python/cpython#24152
Files	issue19683.patch issue19683.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Edit by TJR: The two patch files, by two different people deleted empty tests. Some version was merged to Python maintenance versions 2.7 and 3.3 (then on Mercurial) in Dec 2013: https://github.com/python/cpython/issues/63882#issuecomment-1093635363. At that time, 3.4.0, released in March 2014, was tip. PR 24152 added docstrings to minidom.py, removed the empty tests, and revised existing tests. The author closed it due to lack of time when requested to split it into multiple PRs.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2013-11-21.15:17:39.634>
labels = ['easy', 'type-feature', 'tests']
title = 'test_minidom has many empty tests'
updated_at = <Date 2021-01-07.13:48:32.590>
user = 'https://github.com/zware'

bugs.python.org fields:

activity = <Date 2021-01-07.13:48:32.590>
actor = 'karlcow'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-11-21.15:17:39.634>
creator = 'zach.ware'
dependencies = []
files = ['32901', '33258']
hgrepos = []
issue_num = 19683
keywords = ['patch', 'easy']
message_count = 21.0
messages = ['203637', '203642', '203643', '204781', '204806', '204834', '205274', '206637', '206639', '206641', '206642', '206873', '206939', '206979', '209897', '209899', '353793', '353835', '384561', '384575', '384576']
nosy_count = 7.0
nosy_names = ['r.david.murray', 'karlcow', 'python-dev', 'zach.ware', 'serhiy.storchaka', 'Julian.Gindi', 'ajitesh.gupta']
pr_nums = ['24152']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19683'
versions = ['Python 3.4']