any command with 'secret' doesnt get saved in history, even though no secrets exposed.

未关闭
#5,108 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
csharp
领域
cli

调研方向

Start in History.cs at the linked line and reproduce the behavior with echo 'secret' and echo 'secre', then inspect how history entries are filtered and persisted. Done means commands containing the word secret are retained when they do not expose an actual secret, while the existing history behavior remains intact.

由索引模型根据 Issue 内容生成。

描述

Needs-Triage :mag:

ran a command with 'secrets' and found that it doesnt get stored in history.

what idiot or bot thought it would be a good idea to do this stupid shit? it wasnt a problem before. imagine all the people's
time youve wasted bc they're left guessing why the fuck their command isnt in the history, as if they're supposed to just know.

https://github.com/PowerShell/PSReadLine/blob/e266ca6f67ab081476a0990e36e67ab4f2554e2b/PSReadLine/History.cs#L666

Prerequisites
  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.
Exception report
Screenshot

N/A

Environment data
PS Version: 7.4.13
Steps to reproduce

run echo 'secret' and close the tab and start new and hit up arrow or look at ConsoleHost_history its not there, but not echo 'secre'

Expected behavior

command should be in history. there's no fucking secret in the command, just the string.

Actual behavior

not in history

主要语言
C#
星标
4.4k
派生
341
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。