any command with 'secret' doesnt get saved in history, even though no secrets exposed.

Aberta
#5,108 2 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
68/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Pouca atividade
Stack de tecnologia
csharp
Domínio
cli

Direção de pesquisa

Start in History.cs at the linked line and reproduce the behavior with echo 'secret' and echo 'secre', then inspect how history entries are filtered and persisted. Done means commands containing the word secret are retained when they do not expose an actual secret, while the existing history behavior remains intact.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Needs-Triage :mag:

ran a command with 'secrets' and found that it doesnt get stored in history.

what idiot or bot thought it would be a good idea to do this stupid shit? it wasnt a problem before. imagine all the people's
time youve wasted bc they're left guessing why the fuck their command isnt in the history, as if they're supposed to just know.

https://github.com/PowerShell/PSReadLine/blob/e266ca6f67ab081476a0990e36e67ab4f2554e2b/PSReadLine/History.cs#L666

Prerequisites
  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.
Exception report
Screenshot

N/A

Environment data
PS Version: 7.4.13
Steps to reproduce

run echo 'secret' and close the tab and start new and hit up arrow or look at ConsoleHost_history its not there, but not echo 'secre'

Expected behavior

command should be in history. there's no fucking secret in the command, just the string.

Actual behavior

not in history

Linguagem predominante
C#
Estrelas
4.4k
Forks
341
Nenhum PR com merge em 30d

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de PowerShell/PSReadLine

Todas as issues de PowerShell/PSReadLine

Issues semelhantes

Mais issues de C#

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.