`SamplePSReadLineProfile.ps1` SmartInsertQuote Error On Strict Mode

未关闭 适合新手
#5,121 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
powershell
领域
cli

调研方向

从链接的 SmartInsertQuote 条件处的 PSReadLine/SamplePSReadLineProfile.ps1 开始,并在 Set-StrictMode -Version Latest 下运行示例配置文件。移动到一行末尾并输入引号来重现错误,然后验证 guard 能处理该位置、插入两个引号,并避免 index-out-of-range 异常。

由索引模型根据 Issue 内容生成。

描述

Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.
Exception report
Exception             : 
    Type       : System.IndexOutOfRangeException
    TargetSite : 
        Name          : ThrowIndexOutOfRangeException
        DeclaringType : [Internal.Runtime.CompilerHelpers.ThrowHelpers]
        MemberType    : Method
        Module        : System.Private.CoreLib.dll
    Message    : Index was outside the bounds of the array.
    Source     : System.Private.CoreLib
    HResult    : -2146233080
    StackTrace : 
   at CallSite.Target(Closure, CallSite, Object, Object)
   at System.Management.Automation.EnumerableOps.SlicingIndex(Object target, IEnumerator indexes, Func`3 indexer)
   at <ScriptBlock>(Closure, FunctionContext)
CategoryInfo          : OperationStopped: (:) [], IndexOutOfRangeException
FullyQualifiedErrorId : System.IndexOutOfRangeException
InvocationInfo        : 
    ScriptLineNumber : 393
    OffsetInLine     : 17
    HistoryId        : 111
    ScriptName       : C:\Users\matt\OneDrive\Documents\PowerShell\profile.ps1
    Line             : if ($line[0..$cursor].Where{$_ -eq $quote}.Count % 2 -eq 1) {
                       
    Statement        : $line[0..$cursor].Where{$_ -eq $quote}.Count % 2 -eq 1
    PositionMessage  : At C:\Users\matt\OneDrive\Documents\PowerShell\profile.ps1:393 char:17
                       + …         if ($line[0..$cursor].Where{$_ -eq $quote}.Count % 2 -eq 1) { …
                       +               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    PSScriptRoot     : C:\Users\matt\OneDrive\Documents\PowerShell
    PSCommandPath    : C:\Users\matt\OneDrive\Documents\PowerShell\profile.ps1
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, C:\Users\matt\.local\share\chezmoi\outchezmoiscripts\Sync-ScoopConfig.ps1: line 64
                        at <ScriptBlock>, <No file>: line 1
Screenshot

N/A

Environment data
PS Version: 7.6.0
PS HostName: Visual Studio Code Host
PSReadLine Version: 2.4.4-beta4
PSReadLine EditMode: Vi
OS: 10.0.22621.1 (WinBuild.160101.0800)
BufferWidth: 190
BufferHeight: 19
Steps to reproduce

Run the sample profile with Set-StrictMode -Version Latest . Then go to end of line. Then enter a quote.

Expected behavior

Two quotes should be entered

Actual behavior

Error happens.

Workaround

I edited the below line
https://github.com/PowerShell/PSReadLine/blob/caa53f8469e35f6ba6e1a434d4fc8efae2dde20c/PSReadLine/SamplePSReadLineProfile.ps1#L195
to add $cursor -lt $line.Length -and to beginning of the if block to short circuit and prevent the index out of range. I wasn't sure if $cursor - 1 inside the indexer would be appropriate as I don't completely understand all the code.

主要语言
C#
星标
4.4k
派生
341
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。