ynput / ynput/ayon-python-api

Entity Hub: Refactor get children to work with added entity types support

Open
#198 0 comments 0 reactions 1 assignee View on GitHub

@iLLiCiTiT is already working on this.

Since Oct 28, 2024.

Dominant language
Python
Stars
16
Forks
15
Avg merge
1d 9h
Merged PRs (30d)
10

Description

Is there an existing issue for this?
  • I have searched the existing issues.
Please describe the feature you have in mind and explain what the current shortcomings are?

Current implementation of childrens logic in EntityHub works only for folders and tasks, that does not include products and versions.

How would you imagine the implementation of the feature?

First of all it should be possible to get children of products.

Second issue is that it should be possible to get products as children of folders, but becuase the current logic counts only with folders it is not that easy. When currently available methods are called we should also fetch products with other folders and tasks. But we should add more targetted methods to get only folders, or only products or only tasks, and fetch them and cache their entities respectivelly, so when folder already has known folder entities, but get_children is called we should also look for tasks and products.

Another question is if tasks should option to have version entities as children, because the connection is there we might add it.

Are there any labels you wish to add?
  • I have added the relevant labels to the enhancement request.
Describe alternatives you've considered:

No response

Additional context:

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.