voidzero-dev / voidzero-dev/vite-task

Windows fspy reports the workspace root as a read-write overlap and prevents caching

オープン
#548 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

主要言語
Rust
スター
466
フォーク
42
平均マージ
1日 15時間
マージ済み PR(30日)
19

説明

Summary

A cached task using the default automatic input and output inference completes successfully on Windows, but Vite Task refuses to store the cache entry because fspy reports the workspace root as both read and written.

The same fixture completes without this cache diagnostic on Linux and macOS.

Reproduction

This was captured by a real cross-platform Vite+ snapshot test added while working on voidzero-dev/vite-plus#2151.

The fixture used a real managed Bun 1.3.14 installation rather than a mocked executable. Its configured task was equivalent to:

export default {
  run: {
    tasks: {
      'gate:test': {
        command: 'bun probe',
      },
    },
  },
}

The package script executed a real package binary through Bun:

{
  "scripts": {
    "probe": "bunx --bun probe"
  },
  "dependencies": {
    "probe-bin": "file:./probe-bin"
  },
  "devEngines": {
    "packageManager": {
      "name": "bun",
      "version": "1.3.14",
      "onFail": "download"
    }
  }
}

The snapshot steps were:

vp install
vp run gate:test
vp run --last-details

The command itself succeeded:

$ bun probe
$ bunx --bun probe
probe binary ran

Only the Windows run then reported:

vp run: vite-task-bunx-wrapper#gate:test not cached because it modified its input.

[1] vite-task-bunx-wrapper#gate:test: $ bun probe ✓
    → Not cached: read and wrote ''

The empty relative path is the workspace root. Re-running the task cannot hit the cache because no entry was stored.

Expected behavior

The task should be cacheable when the process tree does not actually modify an inferred input. In this fixture, a subsequent identical run should be able to hit the cache.

Actual behavior

On Windows, fspy reports the workspace root as both read and written. Vite Task treats the empty workspace-relative path as an input/output overlap and skips the cache update.

Analysis

TrackedPathAccesses::from_raw strips the workspace root from absolute paths. An access to the root itself therefore becomes an empty RelativePathBuf, which is retained in both path_reads and path_writes:

https://github.com/voidzero-dev/vite-task/blob/cb580c214bb2314fc1f633a3812782c9b3a1d956/crates/vite_task/src/session/execute/tracked_accesses.rs

observe_fspy then performs an exact intersection between the inferred read and write path sets. The empty path is returned as read_write_overlap, causing CacheNotUpdatedReason::InputModified:

https://github.com/voidzero-dev/vite-task/blob/cb580c214bb2314fc1f633a3812782c9b3a1d956/crates/vite_task/src/session/execute/cache_update.rs

One possible source of the false positive is the Windows access-mode mapping. The Windows preload records the requested access mask when intercepting NtCreateFile/NtOpenFile, before forwarding the real call. Directory access rights share bit values with FILE_WRITE_DATA and FILE_APPEND_DATA, so opening a directory with the capability to add children may be classified as a write even when the process does not mutate it.

The existing diagnostic only contains the aggregated path. It does not identify the originating PID/process, access mask, create disposition/options, or whether the intercepted call succeeded, so the exact syscall in the Bun process tree is not yet known.

A regression test should preserve real root-directory input tracking while ensuring that a directory-handle access which does not mutate the workspace does not make an otherwise cacheable Windows task permanently uncacheable.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

crates/vite_task/src/session/execute/tracked_accesses.rs と cache_update.rs から始め、TrackedPathAccesses::from_raw を追い、observe_fspy を観察して、空の workspace 相対パスがどのようにオーバーラップになるのかを理解します。Windows の vite_task_bunx_wrapper::vite_task_bunx_wrapper ケースを再現し、実際の Bun プロセスツリー周辺の Windows アクセストラッキングを調べます。ルートディレクトリの入力トラッキングを維持する一方で、workspace を変更しないアクセスによってキャッシュが妨げられなくなることを回帰テストで確認できれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
bun, rust
領域
devtools, operating-systems, testing-qa
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
48/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。