voidzero-dev / voidzero-dev/vite-task

Windows fspy reports the workspace root as a read-write overlap and prevents caching

Aperta
#548 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Rust
Stelle
466
Fork
42
Merge medio
1g 15h
PR unite (30g)
19

Descrizione

Summary

A cached task using the default automatic input and output inference completes successfully on Windows, but Vite Task refuses to store the cache entry because fspy reports the workspace root as both read and written.

The same fixture completes without this cache diagnostic on Linux and macOS.

Reproduction

This was captured by a real cross-platform Vite+ snapshot test added while working on voidzero-dev/vite-plus#2151.

The fixture used a real managed Bun 1.3.14 installation rather than a mocked executable. Its configured task was equivalent to:

export default {
  run: {
    tasks: {
      'gate:test': {
        command: 'bun probe',
      },
    },
  },
}

The package script executed a real package binary through Bun:

{
  "scripts": {
    "probe": "bunx --bun probe"
  },
  "dependencies": {
    "probe-bin": "file:./probe-bin"
  },
  "devEngines": {
    "packageManager": {
      "name": "bun",
      "version": "1.3.14",
      "onFail": "download"
    }
  }
}

The snapshot steps were:

vp install
vp run gate:test
vp run --last-details

The command itself succeeded:

$ bun probe
$ bunx --bun probe
probe binary ran

Only the Windows run then reported:

vp run: vite-task-bunx-wrapper#gate:test not cached because it modified its input.

[1] vite-task-bunx-wrapper#gate:test: $ bun probe ✓
    → Not cached: read and wrote ''

The empty relative path is the workspace root. Re-running the task cannot hit the cache because no entry was stored.

Expected behavior

The task should be cacheable when the process tree does not actually modify an inferred input. In this fixture, a subsequent identical run should be able to hit the cache.

Actual behavior

On Windows, fspy reports the workspace root as both read and written. Vite Task treats the empty workspace-relative path as an input/output overlap and skips the cache update.

Analysis

TrackedPathAccesses::from_raw strips the workspace root from absolute paths. An access to the root itself therefore becomes an empty RelativePathBuf, which is retained in both path_reads and path_writes:

https://github.com/voidzero-dev/vite-task/blob/cb580c214bb2314fc1f633a3812782c9b3a1d956/crates/vite_task/src/session/execute/tracked_accesses.rs

observe_fspy then performs an exact intersection between the inferred read and write path sets. The empty path is returned as read_write_overlap, causing CacheNotUpdatedReason::InputModified:

https://github.com/voidzero-dev/vite-task/blob/cb580c214bb2314fc1f633a3812782c9b3a1d956/crates/vite_task/src/session/execute/cache_update.rs

One possible source of the false positive is the Windows access-mode mapping. The Windows preload records the requested access mask when intercepting NtCreateFile/NtOpenFile, before forwarding the real call. Directory access rights share bit values with FILE_WRITE_DATA and FILE_APPEND_DATA, so opening a directory with the capability to add children may be classified as a write even when the process does not mutate it.

The existing diagnostic only contains the aggregated path. It does not identify the originating PID/process, access mask, create disposition/options, or whether the intercepted call succeeded, so the exact syscall in the Bun process tree is not yet known.

A regression test should preserve real root-directory input tracking while ensuring that a directory-handle access which does not mutate the workspace does not make an otherwise cacheable Windows task permanently uncacheable.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia in crates/vite_task/src/session/execute/tracked_accesses.rs e cache_update.rs, seguendo TrackedPathAccesses::from_raw e osservando observe_fspy per capire come il percorso vuoto relativo al workspace diventa una sovrapposizione. Riproduci il caso Windows vite_task_bunx_wrapper::vite_task_bunx_wrapper e ispeziona il tracciamento degli accessi Windows intorno all’albero reale dei processi Bun. Il lavoro è completato quando un test di regressione preserva il tracciamento degli input della directory radice, mentre un accesso che non modifica il workspace non impedisce più il caching.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
bun, rust
Ambito
devtools, operating-systems, testing-qa
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.