stdlib-js / stdlib-js/stdlib

[BUG]: Multiline editing is broken in the REPL

Đang mở
#4,970 1 bình luận 0 reaction 1 người được giao Được @Snehil-Shah nhận Xem trên GitHub
Bug REPL
Ngôn ngữ chính
JavaScript
Star
6k
Fork
1.3k
Merge trung bình
1 ngày 3 giờ
Pull request đã merge (30 ngày)
611

Mô tả

### Description

After keybindings, some multiline editing features like continuous backspaces into the previous line and moving back to the previous line using left arrow, is broken. It's because we are intercepting these keys in the editor actions itself.

Also when the completer tab is on, backspace is acting twice, I believe for the same reason.

This will be fixed when we add the ability to configure existing actions (like the multiline actions itself), where we'll club the logic of backspaces, left arrows, and right arrows in one place.

### Related Issues

Related issues #2647 .

### Questions

No.

### Demo

_No response_

### Reproduction

- Try to hit backspace or left arrow when at the beginning of a line, in a multiline input.

### Expected Results

It should go back to the previous line.

### Actual Results

Doesn't go back to the previous line.

### Environments

Node.js

### Checklist

- [x] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.