stdlib-js / stdlib-js/stdlib

[BUG]: Multiline editing is broken in the REPL

Ouverte
#4,970 1 commentaire 0 réactions 1 personne assignée Réclamée par @Snehil-Shah Voir sur GitHub
Bug REPL
Langage dominant
JavaScript
Étoiles
6k
Forks
1.3k
Merge moyen
1 j 3 h
PR mergées (30 j)
611

Description

### Description

After keybindings, some multiline editing features like continuous backspaces into the previous line and moving back to the previous line using left arrow, is broken. It's because we are intercepting these keys in the editor actions itself.

Also when the completer tab is on, backspace is acting twice, I believe for the same reason.

This will be fixed when we add the ability to configure existing actions (like the multiline actions itself), where we'll club the logic of backspaces, left arrows, and right arrows in one place.

### Related Issues

Related issues #2647 .

### Questions

No.

### Demo

_No response_

### Reproduction

- Try to hit backspace or left arrow when at the beginning of a line, in a multiline input.

### Expected Results

It should go back to the previous line.

### Actual Results

Doesn't go back to the previous line.

### Environments

Node.js

### Checklist

- [x] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.