stdlib-js / stdlib-js/stdlib

[RFC]: Move `from_arraybuffer.js` into `@stdlib/ndarray/from-arraybuffer`

未关闭
#14,965 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Feature JavaScript priority: Low
主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 3 小时
30 天内合并 PR
611

描述

### Description

This RFC proposes acting on the `TODO` in `lib/from_arraybuffer.js`, which notes the helper should move to `@stdlib/ndarray/from-arraybuffer`.

The file is dimension-agnostic and is copied verbatim into each dimensional `ctor` package. There are three copies today, in `vector/ctor`, `matrix/ctor`, and `tensor3d/ctor`. Adding `tensor4d` and `tensor5d` would make five.

Separate work on `@stdlib/ndarray/from-arraybuffer` is already under way, which would reclaim all of them at once.

### Related Issues

Related issues: Parent

### Questions

Should this land before `tensor4d` starts, so the count stops at three?

### Other

No.

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

贡献指南

打开贡献指南

调研方向

Start by reading lib/from_arraybuffer.js and its copies in vector/ctor, matrix/ctor, and tensor3d/ctor, then inspect the separate @stdlib/ndarray/from-arraybuffer work already under way. Done means the helper has been moved there and the dimensional packages no longer carry these duplicate copies before tensor4d and tensor5d are added.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
data
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
活跃
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。