stdlib-js / stdlib-js/stdlib

[RFC]: Move `from_arraybuffer.js` into `@stdlib/ndarray/from-arraybuffer`

Abierto
#14,965 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Feature JavaScript priority: Low
Lenguaje dominante
JavaScript
Estrellas
6k
Forks
1.3k
Merge medio
1 d 3 h
PR fusionados (30 d)
611

Descripción

### Description

This RFC proposes acting on the `TODO` in `lib/from_arraybuffer.js`, which notes the helper should move to `@stdlib/ndarray/from-arraybuffer`.

The file is dimension-agnostic and is copied verbatim into each dimensional `ctor` package. There are three copies today, in `vector/ctor`, `matrix/ctor`, and `tensor3d/ctor`. Adding `tensor4d` and `tensor5d` would make five.

Separate work on `@stdlib/ndarray/from-arraybuffer` is already under way, which would reclaim all of them at once.

### Related Issues

Related issues: Parent

### Questions

Should this land before `tensor4d` starts, so the count stops at three?

### Other

No.

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reading lib/from_arraybuffer.js and its copies in vector/ctor, matrix/ctor, and tensor3d/ctor, then inspect the separate @stdlib/ndarray/from-arraybuffer work already under way. Done means the helper has been moved there and the dimensional packages no longer carry these duplicate copies before tensor4d and tensor5d are added.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
data
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.