stdlib-js / stdlib-js/stdlib

[RFC]: Move `from_arraybuffer.js` into `@stdlib/ndarray/from-arraybuffer`

Ouverte
#14,965 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Feature JavaScript priority: Low
Langage dominant
JavaScript
Étoiles
6k
Forks
1.3k
Merge moyen
1 j 3 h
PR mergées (30 j)
611

Description

### Description

This RFC proposes acting on the `TODO` in `lib/from_arraybuffer.js`, which notes the helper should move to `@stdlib/ndarray/from-arraybuffer`.

The file is dimension-agnostic and is copied verbatim into each dimensional `ctor` package. There are three copies today, in `vector/ctor`, `matrix/ctor`, and `tensor3d/ctor`. Adding `tensor4d` and `tensor5d` would make five.

Separate work on `@stdlib/ndarray/from-arraybuffer` is already under way, which would reclaim all of them at once.

### Related Issues

Related issues: Parent

### Questions

Should this land before `tensor4d` starts, so the count stops at three?

### Other

No.

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by reading lib/from_arraybuffer.js and its copies in vector/ctor, matrix/ctor, and tensor3d/ctor, then inspect the separate @stdlib/ndarray/from-arraybuffer work already under way. Done means the helper has been moved there and the dimensional packages no longer carry these duplicate copies before tensor4d and tensor5d are added.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript
Domaine
data
Type d'issue
Refactorisation
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
35/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.