simvue-io / simvue-io/python-api
Logging Handler often encounters errors
オープン
まだ誰も着手していません。
bug
- 主要言語
- Python
- スター
- 4
- フォーク
- 1
- 平均マージ
- 5日 8時間
- マージ済み PR(30日)
- 4
説明
Description of Bug
When using the logging handler, I often get errors similar to this:
--- Logging error ---
Traceback (most recent call last):
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/handler.py", line 38, in emit
self._run_object.log_event(_msg)
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/utilities.py", line 317, in wrapper
return class_func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/run.py", line 115, in _wrapper
return _function(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/utilities.py", line 355, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/pydantic/_internal/_validate_call.py", line 40, in wrapper_function
return wrapper(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/pydantic/_internal/_validate_call.py", line 137, in __call__
res = self.__pydantic_validator__.validate_python(pydantic_core.ArgsKwargs(args, kwargs))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/run.py", line 1451, in log_event
self._error("Cannot log events when not in the running state")
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/run.py", line 647, in _error
raise SimvueRunError(message)
simvue.exception.SimvueRunError: Cannot log events when not in the running state
Call stack:
File "/__t/Python/3.11.15/x64/lib/python3.11/threading.py", line 1002, in _bootstrap
self._bootstrap_inner()
File "/__t/Python/3.11.15/x64/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
self.run()
File "/__t/Python/3.11.15/x64/lib/python3.11/threading.py", line 982, in run
self._target(*self._args, **self._kwargs)
File "/__w/connectors-fds/connectors-fds/simvue_fds/connector.py", line 877, in _slice_parser
slice_parsed = self._parse_slice()
File "/__w/connectors-fds/connectors-fds/simvue_fds/connector.py", line 801, in _parse_slice
logger.warning(
File "/__t/Python/3.11.15/x64/lib/python3.11/logging/__init__.py", line 1501, in warning
self._log(WARNING, msg, args, **kwargs)
File "/__t/Python/3.11.15/x64/lib/python3.11/logging/__init__.py", line 1634, in _log
self.handle(record)
File "/__t/Python/3.11.15/x64/lib/python3.11/logging/__init__.py", line 1644, in handle
self.callHandlers(record)
File "/__t/Python/3.11.15/x64/lib/python3.11/logging/__init__.py", line 1706, in callHandlers
hdlr.handle(record)
File "/__t/Python/3.11.15/x64/lib/python3.11/logging/__init__.py", line 978, in handle
self.emit(record)
File "/github/home/.cache/pypoetry/virtualenvs/simvue-fds-CpC4W15U-py3.11/lib/python3.11/site-packages/simvue/handler.py", line 40, in emit
logging.Handler.handleError(self, record)
Message: '\n Your Simvue server is out of date, and is running a noSim version\n which is lower than the version required to support OBSTs within 3D metrics.\n Ask your admin to upgrade to noSim version 1.6.4 or higher.\n Falling back to uploading OBSTs as zeros...\n '
Arguments: ()
WARNING simvue_fds.connector:
Your Simvue server is out of date, and is running a noSim version
which is lower than the version required to support OBSTs within 3D metrics.
Ask your admin to upgrade to noSim version 1.6.4 or higher.
Falling back to uploading OBSTs as zeros...
I'm not sure why its trying to send an event when the run is not in the running state, since the logging I am using always does logging within the Run context
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
simvue/handler.py の logging handler の emit メソッドから始め、次に traceback に示されている simvue_fds/connector.py::_parse_slice と _slice_parser からの呼び出しを追跡してください。Run context がアクティブな間に out-of-date-server warning を再現し、Run が running state を離れた後に handler が log_event に到達する理由を特定してください。警告によって報告された logging error が発生しなくなり、その動作が適切なテストでカバーされていれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- observability
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 静か
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 35/100